Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(torii): less noise in logs #2358

Merged
merged 2 commits into from
Aug 28, 2024
Merged

chore(torii): less noise in logs #2358

merged 2 commits into from
Aug 28, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Aug 28, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Improved logging behavior to enhance the clarity of the syncing process.
    • Adjusted log levels to reduce unnecessary information while maintaining detailed debug logs.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 28, 2024 •
edited
Loading

Walkthrough

Ohayo, sensei! The changes involve modifications to the logging behavior within the Engine implementation. An informational log statement regarding the syncing range of blocks has been removed, while another log statement about the total number of event pages fetched has been adjusted from info to debug level. This reflects a shift in logging strategy, focusing on reducing info-level output while maintaining detailed debug logs.

Changes

File Path Change Summary
crates/torii/core/src/engine.rs Removed an informational log about syncing range; changed total event pages fetched log from info to debug level.

Sequence Diagram(s)

sequenceDiagram
    participant Engine
    participant Logger

    Engine->>Logger: Log syncing range (removed)
    Engine->>Logger: Log total event pages fetched (changed to debug)
Loading
Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d0532ea and 617d990.

Files selected for processing (1)
  • crates/torii/core/src/engine.rs (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • crates/torii/core/src/engine.rs
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.51%. Comparing base (d31f81e) to head (617d990).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/torii/core/src/engine.rs 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2358      +/-   ##
==========================================
- Coverage   67.51%   67.51%   -0.01%     
==========================================
  Files         359      359              
  Lines       46955    46956       +1     
==========================================
  Hits        31704    31704              
- Misses      15251    15252       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit cf1d044 into dojoengine:main Aug 28, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glihm glihm glihm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Larkooo @glihm